Implement getConstantStrings() on Type #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
clxmstaab
force-pushed
the
const-strings
branch
from
4b9b059
to
c11ef4b
Compare
staabm
force-pushed
the
const-strings
branch
2 times, most recently
from
86ed04f
to
e387570
Compare
clxmstaab
force-pushed
the
const-strings
branch
from
e387570
to
144304c
Compare
staabm
force-pushed
the
const-strings
branch
2 times, most recently
from
21de8f4
to
fac73f6
Compare
staabm
force-pushed
the
const-strings
branch
from
fac73f6
to
4576fa6
Compare
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
const-strings
branch
from
e75f596
to
6ba53ee
Compare
staabm
force-pushed
the
const-strings
branch
3 times, most recently
from
fe1030d
to
50c106c
Compare
staabm
force-pushed
the
const-strings
branch
from
50c106c
to
3de226d
Compare
|
Thank you! |
schlndh
reviewed
Dec 20, 2022
| @@ -93,6 +93,8 @@ public static function getConstantArrays(Type $type): array | |||
|
|
|||
| /** | |||
| * @return ConstantStringType[] | |||
| * | |||
| * @deprecated Use PHPStan\Type\Type::getConstantStrings() instead | |||
There was a problem hiding this comment.
@staabm The two methods don't work exactly the same (i.e. the new implementation for UnionType doesn't have $stopOnUnmatched equivalent). I think it causes a regression here: https://phpstan.org/r/33df1d6b-50e1-4aed-ac3b-bb5f1a8ac66b (constant string concat with int|null - the result shouldn't be a constant string).
There was a problem hiding this comment.
thx for the headsup. I will have a look.
I opened a issue for it: phpstan/phpstan#8568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#8311