should return TypeObject of AbstractA|AbstractB but returns AbstractA|AbstractB

[arderyp]

Maybe I am missing something?

https://phpstan.org/r/dfa88d94-eb8e-4ab5-8170-455575220e83

Potentially related issue: #4411

[mad-briller]

phpstan currently models types as possibility sets, not control flow, you can learn more from this talk

[arderyp]

thanks for the link @mad-briller, I will check out the talk later today. Always happy to learn more about PHPStan!

That said, the error is confusing, and I still don't see how my example is problematic. It saying the function should return TypeObject of AbstractA|AbstractB and it is literally returning TypeObject, which the generic defines as TypeObject of AbstractA|AbstractB.

But, maybe the talk will enlighten me or give me an idea of how to solve this.

[mad-briller]

sorry @arderyp i misunderstood the error mesage myself,

i thought it was stating that because the method is generic over a single class, but has the possibility to return either AbstractA or AbstractB, phpstan was getting confused by that
but judging by the fix provided by @rvanvelzen i was wrong :D

[arderyp]

I appreciate the video link anyways :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.