Improve intersection of generic class string #1724
Merged
+65
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanvelzen
force-pushed
the
bug-7987
branch
from
bc8b47b to
f3f9fe0
Compare
|
thanks for posting this @rvanvelzen ! |
rvanvelzen
force-pushed
the
bug-7987
branch
from
f3f9fe0 to
d21d846
Compare
ondrejmirtes
requested changes
Sep 20, 2022
| assertType('class-string<Bug4875\Blah>&class-string<Bug4875\Mock>', $mock::class); | ||
| assertType('class-string<Bug4875\Blah>&class-string<Bug4875\Mock>', get_class($mock)); | ||
| assertType('class-string<Bug4875\Blah&Bug4875\Mock>', $mock::class); | ||
| assertType('class-string<Bug4875\Blah&Bug4875\Mock>', get_class($mock)); |
There was a problem hiding this comment.
Can you please explain this a bit? Why class-string<Bug4875\Blah>&class-string<Bug4875\Mock> and class-string<Bug4875\Blah&Bug4875\Mock> aren't equivalent and why this change fixes phpstan/phpstan#7987? Thanks!
There was a problem hiding this comment.
The most important fix is collapsing class-string<T of A|B>&class-string<A> into class-string<T of A>. This allows inferring T more reliably.
Semantically they represent the same thing, and since the collapsed form improves template type inference I think it's better to collapse it.
There was a problem hiding this comment.
thank you both! I will test soon and report back if there are any issues
rvanvelzen
force-pushed
the
bug-7987
branch
from
d21d846 to
64b4c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix phpstan/phpstan#7987