Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to hook custom rule to some Attribute-related nodes like AttributeGroup #7071

Closed
janedbal opened this issue Apr 20, 2022 · 2 comments · Fixed by phpstan/phpstan-src#1333

Comments

@janedbal
Copy link
Contributor

Bug report

NodeScopeResolver is not calling rule callback for some nodes like AttributeGroup or its Args

Code snippet that reproduces the problem

class CustomRule implements Rule
{

    public function getNodeType(): string
    {
        return \PhpParser\Node\AttributeGroup::class;
    }

    public function processNode(Node $node, Scope $scope): array
    {
        return ['Never reported'];
    }

}

Expected output

Error reported.

@mergeable
Copy link

mergeable bot commented Apr 20, 2022

This bug report is missing a link to reproduction at phpstan.org/try.

It will most likely be closed after manual review.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants