Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeScopeResolver: call nodeCallback for all attribute-related nodes #1333

Merged
merged 4 commits into from May 27, 2022
Merged

NodeScopeResolver: call nodeCallback for all attribute-related nodes #1333

merged 4 commits into from May 27, 2022

Conversation

janedbal
Copy link
Contributor

@staabm
Copy link
Contributor

staabm commented May 20, 2022

should contain a regression test for the issue being fixed

@janedbal
Copy link
Contributor Author

Tests added

@ondrejmirtes
Copy link
Member

Please fix the build. Lint can be fixed by adding // lint >= 7.4 comments, tests should be fixed by skipping on unsupported PHP versions. Thanks.

ondrejmirtes
ondrejmirtes requested changes May 20, 2022
View reviewed changes
src/Analyser/NodeScopeResolver.php Outdated Show resolved Hide resolved
@ondrejmirtes
Copy link
Member

FYI this will conflict with your PR #1338, please update your code too.

@ondrejmirtes ondrejmirtes merged commit 68d2e81 into phpstan:1.7.x May 27, 2022
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@janedbal @staabm @ondrejmirtes