Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary operations on non-empty-string and string gives different results #6624

Closed
canvural opened this issue Feb 10, 2022 · 1 comment · Fixed by phpstan/phpstan-src#1010
Closed
Labels
Milestone

Comments

@canvural
Copy link
Contributor

Bug report

Hi,

Binary operations between string and int, gives errors as expected. Except dividing!

But the same operations between non-empty-string and int does not produce any error.

In runtime these all error.

Code snippet that reproduces the problem

https://phpstan.org/r/980008ff-df01-4485-aab0-1fd7b8a73f55

<?php declare(strict_types = 1);

/** @var non-empty-string $foo */
/** @var string $bar */

echo ($foo + 10); // Should error
echo ($foo - 10); // Should error
echo ($foo * 10); // Should error
echo ($foo / 10); // Should error

echo ($bar + 10); // Gives error correctly
echo ($bar - 10); // Gives error correctly
echo ($bar * 10); // Gives error correctly
echo ($bar / 10); // Should error

Expected output

Error is expected for the operations on $foo

Did PHPStan help you today? Did it make you happy in any way?

Yes!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants