Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect array size when using unset #6488

Closed
tjveldhuizen opened this issue Jan 30, 2022 · 2 comments · Fixed by phpstan/phpstan-src#971
Closed

Incorrect array size when using unset #6488

tjveldhuizen opened this issue Jan 30, 2022 · 2 comments · Fixed by phpstan/phpstan-src#971
Labels
bug
Milestone
Easy fixes

Comments

@tjveldhuizen
Copy link

Bug report

When I conditionally remove items from an array by using unset(), the possible sizes of the array are incorrect

Code snippet that reproduces the problem

https://phpstan.org/r/b4ad7637-32a2-4df6-b392-84e57180a55b

Expected output

Since the array can have any size >= 0, no error should be detected.

Did PHPStan help you today? Did it make you happy in any way?

Always!
@ondrejmirtes
Copy link
Member

Works with count(): https://phpstan.org/r/f0c21ad2-2aca-403f-8cfc-77f22cd24daf

@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Jan 31, 2022
@staabm staabm mentioned this issue Feb 1, 2022
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Easy fixes
Development

Successfully merging a pull request may close this issue.

Fix incorrect array size when using unset staabm/phpstan-src
2 participants
@ondrejmirtes @tjveldhuizen