Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect array size when using unset #971

Merged
merged 2 commits into from Feb 7, 2022
Merged

Fix incorrect array size when using unset #971

merged 2 commits into from Feb 7, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Feb 1, 2022

@staabm staabm changed the title added failling test for bug6488 Fix incorrect array size when using unset Feb 1, 2022
@staabm
Copy link
Contributor Author

staabm commented Feb 1, 2022

build failures seem unrelated and should be fixed by #972

@staabm staabm marked this pull request as ready for review February 1, 2022 16:54
@ondrejmirtes
Copy link
Member

Please rebase because of the conflict (add new lines at the bottom of the dataProvider, not the top), otherwise 👍

@staabm
Copy link
Contributor Author

staabm commented Feb 7, 2022

rebased

@ondrejmirtes ondrejmirtes merged commit bd4f179 into phpstan:master Feb 7, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the bug6488 branch February 7, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@staabm @ondrejmirtes @clxmstaab