Wrong assignation to ArrayAccess&SomeOtherType not reported

[julienfalque]

Bug report

When assigning a wrong new value to a variable of type ArrayAccess, the error is not reported if the type of the variable includes an intersection with another type.

Code snippet that reproduces the problem

class Foo
{
    /** @var \ArrayAccess<int, string> */
    private $collection1;

    /** @var \ArrayAccess<int, string>&\Countable */
    private $collection2;

    public function foo(): void
    {
        $this->collection1[] = 1;
        $this->collection2[] = 2;
    }
}

https://phpstan.org/r/8142895e-0a04-44b6-82c9-e1eed898da54

Expected output

Both assignations should be reported as they don't accept int.

[phpstan-bot]

@julienfalque After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+ 6: Property Foo::$collection1 is never written, only read.
+ 9: Property Foo::$collection2 is never written, only read.
 13: ArrayAccess<int, string> does not accept int.

Full report

Line	Error
6	Property Foo::$collection1 is never written, only read.
9	Property Foo::$collection2 is never written, only read.
13	ArrayAccess<int, string> does not accept int.

[phpstan-bot]

@julienfalque After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+ 6: Property Foo::$collection1 is never read, only written.
+ 9: Property Foo::$collection2 is never read, only written.
 13: ArrayAccess<int, string> does not accept int.

Full report

Line	Error
6	Property Foo::$collection1 is never read, only written.
9	Property Foo::$collection2 is never read, only written.
13	ArrayAccess<int, string> does not accept int.

[phpstan-bot]

@julienfalque After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: ArrayAccess<int, string> does not accept int.
+ 6: Property Foo::$collection1 is never read, only written.
+ 9: Property Foo::$collection2 is never read, only written.
+13: ArrayAccess<int, string> does not accept int.
+13: Property Foo::$collection1 (ArrayAccess<int, string>) does not accept array{1}.
+14: Property Foo::$collection2 (ArrayAccess<int, string>&Countable) does not accept array{2}.

Full report

Line	Error
6	Property Foo::$collection1 is never read, only written.
9	Property Foo::$collection2 is never read, only written.
13	ArrayAccess<int, string> does not accept int.
13	Property Foo::$collection1 (ArrayAccess<int, string>) does not accept array{1}.
14	Property Foo::$collection2 (ArrayAccess<int, string>&Countable) does not accept array{2}.

[phpstan-bot]

@julienfalque After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: ArrayAccess<int, string> does not accept int.
+ 6: Property Foo::$collection1 is never read, only written.
+ 9: Property Foo::$collection2 is never read, only written.
+13: ArrayAccess<int, string> does not accept int.
+14: Property Foo::$collection2 (ArrayAccess<int, string>&Countable) does not accept Countable.

Full report

Line	Error
6	Property Foo::$collection1 is never read, only written.
9	Property Foo::$collection2 is never read, only written.
13	ArrayAccess<int, string> does not accept int.
14	Property Foo::$collection2 (ArrayAccess<int, string>&Countable) does not accept Countable.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@3b5fd94

[julienfalque]

Thank you @ondrejmirtes!

[julienfalque]

Shouldn't the last error be

14: ArrayAccess<int, string>&Countable does not accept int.

?

[ondrejmirtes]

Yes, it should, but for complicated reasons this is the best we can do right now.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.