Support ArrayAccess in AppendedArrayItemTypeRule #845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm missed the failing integration test.. |
|
Solution here seems too hacky and messy around generics and iterables, therefore closing this PR. Anybody feel free to copy stuff from it if needed |
herndlm
deleted the
feature/support-array-access-in-appended-array-item-type-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#6184
But I noticed too late that this is also covered by
OffsetAccessValueAssignmentRule, so maybe #843 should be preferred when ready as it handles all offset assignments. I took a quick look but did not get far because it works quite differently and the problems are others