Remember stub files and their errors in result cache

[dktapps]

Feature request

While debugging #5825 , I'm discovering a range of interesting problems, mostly due to Windows' slow I/O.

I found it interesting that StubValidator doesn't use the result cache at all, because validating stubs takes nearly 25% of the pre-analysis step time (under xdebug that's about 1 second out of 4; at normal runtime it would be closer to 300ms).

This might seem insignificant, but I find it odd that stubs aren't remembered by the result cache like normal files.

I'm looking to save all the pre-analyse time I can find here, because this pre-analyse lag is a pretty huge annoyance for using PHPStan on Windows (particularly when integrated with PHPStorm, because it takes quite some time to respond - 300ms is a pretty significant amount of time in that case).

[dktapps]

Some more context on this: about 15% of the time is actually spent to generate the Nette DI container for config.stubValidator.neon. Only 10% is actually analysing the files themselves (though still unnecessarily). Go figure.

[staabm]

Maybe its related nette/di#269

[dktapps]

Not sure. But one way or another, this extra 25% time can be avoided quite easily.

[ondrejmirtes]

Done: phpstan/phpstan-src@d96e8f0

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.