AnalyseApplication: Do not re-analyse stubs on every run #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, only analyse them on full runs. Since a change in any stub already invalidates the whole result cache, this means we only need to analyse them on full runs and then remember their errors for later.
|
As an added bonus (?) this also fixes ignoring stub errors - on 0.12.99, they'd be added to auto-generated baselines, but PHPStan wouldn't pay any attention to the baseline. I'm not sure ignoring stub errors is desirable, but the way it works (or doesn't) on 0.12.99 is obviously broken, regardless of what it was supposed to do. |
|
Build failure looks unrelated. |
This was referenced Oct 24, 2021
|
Yeah I did notice this when I first implemented it, but I didn't think anything of it. Since they were able to end up in baseline but wouldn't get ignored anyway, I assumed it was a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, only analyse them on full runs. Since a change in any stub already invalidates the whole result cache, this means we only need to analyse them on full runs and then remember their errors for later.
On pmmp/PocketMine-MP, this reduces the time to re-analyse with a result cache from ~1300ms to ~1000ms on an XPS 17 9710.
This is a rough shot at implementing phpstan/phpstan#5826.