False positive: Access to private property $root of parent class Foo.

[jkufner]

Bug report

Accessing private property of inherited class from parent class (where the property is defined) is valid, but PHPStan does not like it.

Code snippet that reproduces the problem

https://phpstan.org/r/2c1e2424-3b4d-4a31-aca7-0e8c74633a86

<?php

class Foo {
	/** @var Bar|null */
	private $root;
	
	public function checkRoot(): bool {
		return $this->root->root !== null;
	}
}

class Bar extends Foo {
}

+--------------------------------------------------------------+
| Line | test.php                                              |
+--------------------------------------------------------------+
| 8    | Access to private property $root of parent class Foo. |
+--------------------------------------------------------------+

Expected output

The code is fine. PHPStan should be quiet.

[ondrejmirtes]

Thanks. Proof that it works: https://3v4l.org/GH1v2

[staabm]

I guess fix needs to be in https://github.com/phpstan/phpstan-src/blob/73406572636be4ae9c63ae892cef9e733181116d/src/Rules/Properties/AccessPropertiesRule.php

[phpstan-bot]

@jkufner After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+5: Property Foo::$root is never written, only read.
 8: Access to private property $root of parent class Foo.

Full report

Line	Error
5	Property Foo::$root is never written, only read.
8	Access to private property $root of parent class Foo.

[phpstan-bot]

@jkufner After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-8: Access to private property $root of parent class Foo.
+8: Access to private property $root of parent class Foo.
+5: Property Foo::$root is never written, only read.

Full report

Line	Error
8	Access to private property $root of parent class Foo.
5	Property Foo::$root is never written, only read.

[phpstan-bot]

@jkufner After the latest push in 1.9.x, PHPStan now reports different result with your code snippet:

@@ @@
-8: Access to private property $root of parent class Foo.
+5: Property Foo::$root is never written, only read.

Full report

Line	Error
5	Property Foo::$root is never written, only read.

[phpstan-bot]

@jkufner After the latest push in 1.9.x, PHPStan now reports different result with your code snippet:

@@ @@
-8: Access to private property $root of parent class Foo.
+5: Property Foo::$root is never written, only read.

Full report

Line	Error
5	Property Foo::$root is never written, only read.

[phpstan-bot]

@jkufner After the latest push in 1.9.x, PHPStan now reports different result with your code snippet:

@@ @@
-8: Access to private property $root of parent class Foo.
+5: Property Foo::$root is never written, only read.

Full report

Line	Error
5	Property Foo::$root is never written, only read.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.