Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive of access to private property of parent class #1953

Merged
merged 4 commits into from Nov 9, 2022

Conversation

tyabu12
Copy link
Contributor

@tyabu12 tyabu12 commented Nov 2, 2022

@herndlm
Copy link
Contributor

herndlm commented Nov 9, 2022

according to the new bot, your PR would be closing 3 issues 🎉 https://github.com/phpstan/phpstan-src/actions/runs/3428507295

@ondrejmirtes
Copy link
Member

Please add regression tests for them too :) Thank you.

@ondrejmirtes
Copy link
Member

When I get around to it, I'll add some smart commenting feature on PRs too. My idea is that when the bot finds changes, it adds a comment with them, but with further force-pushes, it doesn't add new comments, it just edits the first one.

@ondrejmirtes ondrejmirtes merged commit b4ac8a1 into phpstan:1.9.x Nov 9, 2022
@ondrejmirtes
Copy link
Member

Perfect, thank you!

@tyabu12 tyabu12 deleted the bug-2435 branch November 9, 2022 14:14
@tyabu12
Copy link
Contributor Author

tyabu12 commented Nov 9, 2022

@ondrejmirtes
Thank you for merging!
Could you also close the following issue that herndlm mentions?

@ondrejmirtes
Copy link
Member

Don't worry, I always do that, that's what the bot is for 😊

@staabm
Copy link
Contributor

staabm commented Nov 9, 2022

@tyabu12 I am wondering whether we have the same problem in static context in AccessPrivatePropertyThroughStaticRule

https://phpstan.org/r/a757dd9c-01fa-450a-96f6-52a10feab73f
https://3v4l.org/YmKc6

@tyabu12
Copy link
Contributor Author

tyabu12 commented Nov 9, 2022

@staabm
It seems that we still have the same problem in the rule.
Could you open new issue for it?

@staabm
Copy link
Contributor

staabm commented Nov 9, 2022

here we go: phpstan/phpstan#8333

@tyabu12
Copy link
Contributor Author

tyabu12 commented Nov 9, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants