New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positive of access to private property of parent class #1953
Conversation
according to the new bot, your PR would be closing 3 issues 🎉 https://github.com/phpstan/phpstan-src/actions/runs/3428507295 |
Please add regression tests for them too :) Thank you. |
When I get around to it, I'll add some smart commenting feature on PRs too. My idea is that when the bot finds changes, it adds a comment with them, but with further force-pushes, it doesn't add new comments, it just edits the first one. |
Perfect, thank you! |
@ondrejmirtes |
Don't worry, I always do that, that's what the bot is for 😊 |
@tyabu12 I am wondering whether we have the same problem in static context in https://phpstan.org/r/a757dd9c-01fa-450a-96f6-52a10feab73f |
@staabm |
here we go: phpstan/phpstan#8333 |
Thank you! |
fix phpstan/phpstan#2435