Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integerish #121

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Fix integerish #121

merged 1 commit into from
Mar 5, 2022

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Mar 3, 2022

Closes #32

Fixed via 2 steps

So this fix only works with the next PHPStan version.

@herndlm
Copy link
Contributor Author

herndlm commented Mar 3, 2022

Extremely glad that this long-outstanding bug is finally fixed 🎉

@ondrejmirtes
Copy link
Member

Makes complete sense :) Thank you.

@ondrejmirtes ondrejmirtes merged commit 2c46094 into phpstan:master Mar 5, 2022
@herndlm herndlm deleted the fix-integerish branch March 5, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert::integerish() with floats/numeric will always evaluate to false
2 participants