Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isNotA #115

Merged
merged 1 commit into from Feb 28, 2022
Merged

Support isNotA #115

merged 1 commit into from Feb 28, 2022

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Feb 27, 2022

Seems to be still blocked by phpstan/phpstan#6704

@ondrejmirtes
Copy link
Member

After merging phpstan/phpstan-src#1040 this might work.

@herndlm
Copy link
Contributor Author

herndlm commented Feb 28, 2022

Yep looking good. Rebased and added 2 more test cases for const class strings to have more similar tests like isAOf has

@herndlm herndlm marked this pull request as ready for review February 28, 2022 10:16
@ondrejmirtes ondrejmirtes merged commit 11cc4ba into phpstan:master Feb 28, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@herndlm herndlm deleted the support-is-not-a branch February 28, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants