Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test #109

Merged
merged 1 commit into from Feb 25, 2022
Merged

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Feb 25, 2022

Closes #33

Was fixed with phpstan/phpstan#6696 / phpstan/phpstan-src@cc6655f

Also double-checked here that this fails with PHPStan 1.4.6.

Looking forward already to the next phpstan and phpstan-webmozart-assert release. I'll try to take a look at a few more issues here, hopefully I can squeeze in a bit more :)

@ondrejmirtes ondrejmirtes merged commit 9d450a4 into phpstan:master Feb 25, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@herndlm herndlm deleted the add-regression-test branch February 25, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert::nullOrStringNotEmpty() with string|null will always evaluate to true
2 participants