Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support greater, less and range assertions #107

Merged

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Feb 19, 2022

The nullOr* are currently not fully working as expected because of phpstan/phpstan#6672
But this still adds value and could be added already IMO.
working now, since the bug has been fixed :)

@ondrejmirtes
Copy link
Member

Please ping me once you mark this as ready.

@herndlm herndlm force-pushed the support-greater-less-and-range-assertions branch from 99af6fc to c257257 Compare February 22, 2022 20:42
@herndlm
Copy link
Contributor Author

herndlm commented Feb 22, 2022

@ondrejmirtes ping :)

Fyi there are a couple other "low hanging fruit" PRs ready as well, in case you have a bit of spare time

@herndlm herndlm marked this pull request as ready for review February 22, 2022 20:44
@ondrejmirtes ondrejmirtes merged commit b9233c3 into phpstan:master Feb 23, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@herndlm herndlm deleted the support-greater-less-and-range-assertions branch October 2, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants