Add stubs for Acl

[VincentLanglet]

No description provided.

[VincentLanglet]

Hi @ondrejmirtes, any idea about this error ?

PHPStan Symfony Framework extensions and rules > phpstan:


In StubPhpDocProvider.php line 150:
                   
  Internal error.  
                   

analyse [--paths-file PATHS-FILE] [-c|--configuration CONFIGURATION] [-l|--level LEVEL] [--no-progress] [--debug] [-a|--autoload-file AUTOLOAD-FILE] [--error-format ERROR-FORMAT] [--generate-baseline [GENERATE-BASELINE]] [--memory-limit MEMORY-LIMIT] [--xdebug] [--fix] [--watch] [--pro] [--] [<paths>...]

[ondrejmirtes]

AclProviderInterface.stub contains a parse error: https://phpstan.org/r/5b9d1718-66c8-40e6-8c0b-d9363de991f7

[mhujer]

There is a space in the beginning of the line which causes the error 😄

Suggested change

	<?php
	<?php

[ondrejmirtes]

With PHPStan's dev-master, the experience is a bit nicer:

------ --------------------------------------------------------------------------------------------
  Line   stubs/Symfony/Component/Security/Acl/Model/AclProviderInterface.stub
 ------ --------------------------------------------------------------------------------------------
  3      Namespace declaration statement has to be the very first statement in the script on line 3
  3      Namespace declaration statement has to be the very first statement in the script on line 3
  3      Namespace declaration statement has to be the very first statement in the script on line 3
  3      Namespace declaration statement has to be the very first statement in the script on line 3
 ------ --------------------------------------------------------------------------------------------

[VincentLanglet]

Whoah, nice catch

[VincentLanglet]

This seems to be ready now :)

[ondrejmirtes]

Thank you!

[VincentLanglet]

I'm not sure the stub is working as expected. @ondrejmirtes

The following PR is failing:
sonata-project/SonataAdminBundle#7095

    /**
     * @var MutableAclProviderInterface
     */
    protected $aclProvider;

    public function getObjectAcl(ObjectIdentityInterface $objectIdentity)
    {
        try {
            return $this->aclProvider->findAcl($objectIdentity);
        } catch (AclNotFoundException $e) {
            return null;
        }
    }

is throwing an error

Method                                                                 
         Sonata\AdminBundle\Security\Handler\AclSecurityHandler::getObjectAcl(  
         ) should return                                                        
         Symfony\Component\Security\Acl\Model\MutableAclInterface|null but      
         returns Symfony\Component\Security\Acl\Model\AclInterface.

even if the stub is

    /**
     * @phpstan-param array<SecurityIdentityInterface> $sids
     * @phpstan-return MutableAclInterface
     */
    public function findAcl(ObjectIdentityInterface $oid, array $sids = []);

[ondrejmirtes]

@VincentLanglet Please open an issue.

[VincentLanglet]

Done #149