New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression #995

Merged

ondrejmirtes merged 1 commit into phpstan:master from arnaud-lb:bug-5591-2

Feb 4, 2022

Contributor

arnaud-lb commented Feb 4, 2022 •

edited

Fixes a regression introduced in #992

For UnionType::accepts(TemplateUnionType) to work, we must treat it as a non-UnionType

Actually we need to treat the TemplateUnionType as both a non-UnionType and a UnionType for these two cases:

(T|null)->accepts(T)
(int|float)->accepts(T of (int|float))

In case 1 the TemplateUnionType acts as a member of the UnionType
In case 2 the TemplateUnionType acts as a UnionType


          Fix regression

12e2fad

ondrejmirtes merged commit 705b460 into phpstan:master

Member

ondrejmirtes commented Feb 4, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment