Delegate most of TypeCombinator::remove() to Type::tryRemove() #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you didn't commit the NonRemoveableTypeTrait trait :) |
ondrejmirtes
reviewed
Feb 4, 2022
| @@ -34,6 +35,8 @@ | |||
| class IntersectionType implements CompoundType | |||
| { | |||
|
|
|||
| use NonRemoveableTypeTrait; | |||
There was a problem hiding this comment.
As I see this trait being used by a lot of types, I'm pretty sure we could actually make them support type-removing in some scenarios :) But we can leave it for later.
|
The failures are from a faulty extension in phpstan-symfony, I'll look into it after merging. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#6438