implemented constant-type inference in ImplodeFunctionReturnTypeExtension #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Feb 4, 2022
Comment on lines
-38
to
-51
| $accessoryTypes = []; | ||
| if ($argType->isIterableAtLeastOnce()->yes() && $argType->getIterableValueType()->isNonEmptyString()->yes()) { | ||
| $accessoryTypes[] = new AccessoryNonEmptyStringType(); | ||
| } | ||
| if ($argType->getIterableValueType()->isLiteralString()->yes()) { | ||
| $accessoryTypes[] = new AccessoryLiteralStringType(); | ||
| } | ||
|
|
||
| if (count($accessoryTypes) > 0) { | ||
| $accessoryTypes[] = new StringType(); | ||
| return new IntersectionType($accessoryTypes); | ||
| } | ||
|
|
||
| return new StringType(); |
There was a problem hiding this comment.
this code was duplicated in the extension. de-duplicated the existing logic with the first commit with 180b2af
staabm
commented
Feb 4, 2022
| @@ -7,9 +7,9 @@ | |||
| class HelloWorld | |||
| { | |||
|
|
|||
| protected function foo(string $message): void | |||
| protected function foo(string $message, string $x): void | |||
There was a problem hiding this comment.
adjusted the existing test, so it still leads to the same result as before this PR.
staabm
commented
Feb 4, 2022
| @@ -206,10 +206,10 @@ public function doFoo4(string $s, array $nonEmptyArrayWithNonEmptyStrings): void | |||
| assertType('non-empty-string', implode($nonEmptyArrayWithNonEmptyStrings)); | |||
| } | |||
|
|
|||
| public function sayHello(): void | |||
| public function sayHello(int $i): void | |||
There was a problem hiding this comment.
adjusted the existing test, so it still leads to the same result as before this PR.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow phpstan-dba to check syntax errors in queries which use
implodelike$query = 'SELECT * FROM abc WHERE id IN ('. implode(',', [A::ONE, B::TWO, 3]) .')';I am aware that such queries are not optimal use and should better be expressed with a prepared statement and separated values, but I think there is a lot of code out their constructed like this .. would be great phpstan-dba could cover such existing but non-optimal query-code