Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiply by zero is always zero #974

Merged
merged 3 commits into from Feb 6, 2022
Merged

multiply by zero is always zero #974

merged 3 commits into from Feb 6, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Feb 1, 2022

ondrejmirtes
ondrejmirtes requested changes Feb 1, 2022
View reviewed changes
tests/PHPStan/Analyser/data/math.php Outdated
public function multiplyZero(int $i, float $f, $range): void
{
assertType('0', $i * 0);
assertType('0', $f * 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Float multiplied by zero is a float: https://3v4l.org/u6dA6

It also works for strings: https://3v4l.org/Ksheh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. fixed

@ondrejmirtes ondrejmirtes merged commit 5087733 into phpstan:master Feb 6, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the multiplyZero branch February 6, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@staabm @ondrejmirtes @clxmstaab