Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameter to Phar::getMetadata() #944

Closed
wants to merge 1 commit into from
Closed

Add missing parameter to Phar::getMetadata() #944

wants to merge 1 commit into from

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Jan 25, 2022

Hi,

An new parameter $unserializeOptions has been added in PHP 8.0 to Phar::getMetadata() and PharFileInfo::getMetadata() (see php/php-src@0c238ede0).

Documentation:

@ondrejmirtes
Copy link
Member

What issue are you trying to solve? Looks to me that it works correctly: https://phpstan.org/r/9509b605-9911-480e-a0d7-ac08b103bd9b

@villfa
Copy link
Contributor Author

villfa commented Jan 25, 2022

I've got a false positive with Psalm ( vimeo/psalm#7486 ), and since PHPStan had the same flaw in the declaration of the PHP8 delta, I assumed it should be fixed too.

Sorry for not having double-checked before, and for the noise.

@villfa villfa closed this Jan 25, 2022
@villfa villfa deleted the patch-1 branch January 26, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants