Fix array_filter with callback that always evaluates to false #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nope, it should be an empty ConstantArrayType 😊 |
|
ah forgot that the tests still need to run with older PHP versions too.. |
thought about that too hmm, I was afraid it might mess things up if e.g. later on elements are added again. Update: tested and seems to be behaving just fine. |
ondrejmirtes
requested changes
Jan 23, 2022
staabm
reviewed
Jan 23, 2022
|
The remaining failing checks (5x phpstan-doctrine OOM, 1x composer) are the same I saw elsewhere too IIRC, should be fine. |
|
I added more tests for already existing, unchanged behaviour. Hope that's fine. My plan is to refactor and add features in 1 or 2 follow-up PRs and already existing tests would be very useful then :) |
|
Thank you! |
herndlm
deleted the
fix-array-filter-return-type-narrowing-with-callback-that-always-evaluates-to-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the return type narrowing if the callback evaluates to false. E.g. an
int[]array is used together with ais_stringcallback. In that case the filtered type inArrayFilterFunctionReturnTypeReturnTypeExtensionwould bearray<*NEVER*>which does not make sense.We found this in https://github.com/phpstan/phpstan-src/pull/938/files#r790184831.