Use positive integers for various time functions #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I'm not a big fan of changing parameter types like this right now in a minor version, it's bound to break someone's build and in fact it's not going to find any real bugs.
I don't know what's the purpose of CallMap_historical.php. |
|
So to be more specific - I'd like to change return types only, that's useful. |
I see. thanks for the insights. fixed per feedback |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by vimeo/psalm#6861
the psalm PR also changes some singatures in a CallMap_historical.php file.. do we have an equivalent in phpstan?