Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved performance of ContainerFactory::clearOldContainers() #733

Closed
wants to merge 5 commits into from
Closed

Improved performance of ContainerFactory::clearOldContainers() #733

wants to merge 5 commits into from

Commits on Oct 24, 2021

  1. Significantly improved performance of ContainerFactory::clearOldConta… 

    …iners() on Windows

Use native FilesystemIterator instead of Symfony Finder. This is because FilesystemIterator does not recurse. I observed that over 50% of the time spent in this function was just calling RecursiveDirectoryIterator::hasChildren(). Eliminating this slashes 1000ms off pre-analysis time on my laptop when the tmpdir contains 30k files (5.6sec vs 4.6sec).
    @dktapps
    dktapps committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    e3db494 View commit details
    Browse the repository at this point in the history

  2. Move getRealPath() call to where it's actually needed 

    this shaves off an additional 1300ms in the same scenario as previous.
    @dktapps
    dktapps committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    5d80fb9 View commit details
    Browse the repository at this point in the history

  3. fix CS

    @dktapps
    dktapps committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    635c256 View commit details
    Browse the repository at this point in the history

  4. YUUUUUUUGE performance improvement for full analysis with heavily pop… 

    …ulated cache

this change reduces full analysis time of pmmp/PocketMine-MP from 33sec to 13sec (no result cache)
    @dktapps
    dktapps committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    5b784ad View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:phpstan/phpstan-src into clear-ol… 

    …d-containers-perf
    @dktapps
    dktapps committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    bdccbfe View commit details
    Browse the repository at this point in the history