More precise signatures for mb_* functions #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 15, 2021
| 'mb_strstr' => ['string|false', 'haystack'=>'string', 'needle'=>'string', 'part='=>'bool', 'encoding='=>'string'], | ||
| 'mb_strtolower' => ['string', 'str'=>'string', 'encoding='=>'string'], | ||
| 'mb_strtoupper' => ['string', 'str'=>'string', 'encoding='=>'string'], | ||
| 'mb_strwidth' => ['int', 'str'=>'string', 'encoding='=>'string'], | ||
| 'mb_strwidth' => ['0|positive-int', 'str'=>'string', 'encoding='=>'string'], |
There was a problem hiding this comment.
|
.. working on the test errors.. |
|
rebased |
|
Still doesn't pass. |
staabm
commented
Feb 1, 2022
| @@ -74,6 +75,11 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection, | |||
| $returnType = ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getReturnType(); | |||
| $positionEncodingParam = $this->encodingPositionMap[$functionReflection->getName()]; | |||
|
|
|||
| // php8-stubs define a regular int return-type for mb_strlen. use a more precise type instead. | |||
There was a problem hiding this comment.
it seems ParametersAcceptorSelector::selectSingle doesn't pick the return type from the functionMap but from the php8 stubs, where mb_strlen is defined with a int return type.
therefore we need this additional if-case
There was a problem hiding this comment.
Can you try putting 0|positive-int return type in functionMap_php80delta.php and delete this condition? It might work.
There was a problem hiding this comment.
ahh that worked - thanks!
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by the correspsonding non-mb functions