Fix 4949, support closure bind with class-string #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
closure_bind_class_string
branch
from
75cdfda
to
e0f5a41
Compare
ondrejmirtes
requested changes
Oct 12, 2021
mvorisek
force-pushed
the
closure_bind_class_string
branch
from
88c36dd
to
97b71e4
Compare
|
@ondrejmirtes can you please review this PR? Also, the releases stopped at 0.12.99 about 2 months ago, is it planned and does it mean some big changes are comming? |
|
I belive this PR is done, can you please review and merge? Thanks. |
|
@ondrejmirtes can you please review this PR? |
|
@mvorisek You're in the same pool as everyone else so you have to wait |
ondrejmirtes
requested changes
Jan 31, 2022
src/Analyser/NodeScopeResolver.php
Outdated
| } elseif ($argValueType instanceof ConstantStringType) { | ||
| $scopeClass = $argValueType->getValue(); | ||
| $thisType = new ObjectType($scopeClass); | ||
| } elseif ( | ||
| $argValueType instanceof GenericClassStringType | ||
| && $argValueType->getGenericType() instanceof ObjectType |
There was a problem hiding this comment.
instanceof TypeWithClassName would be better. Otherwise 👍 .
mvorisek
force-pushed
the
closure_bind_class_string
branch
from
97b71e4
to
5ef1b3f
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#4949