Add InvalidNullCoalesce as level 4 rule #70
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#2371 & phpstan/phpstan#2504
I've implemented it as a level 4 rule, as that is where other 'always true & always false' rules are.
There is probably some cs issues in here as i couldn't get cs-fixer to run on php 7.4 on my local machine.
If this looks good i'll go ahead and fix the issues found by this new rule as well