False positive with when using in_array with literals (or constants) #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
changed the title
staabm
commented
Sep 11, 2021
| @@ -103,6 +104,10 @@ public function findSpecifiedType( | |||
| return null; | |||
| } | |||
|
|
|||
| if ($needleType instanceof ConstantType && !$haystackType instanceof ConstantArrayType) { | |||
There was a problem hiding this comment.
I tried different approaches on how to fix the added failling tests.
no matter which one I implement, some tests start failling.
The PR as is fixed the newly added cases but regresses existing tests.
I need to sleep over it. any hints welcome
There was a problem hiding this comment.
Yes, in_array is a mad beast. It might need a complete rethinking of this approach.
This is also an opportunity to fix https://github.com/phpstan/phpstan/issues/5355 - it means that these conditions should not be in ImpossibleCheckTypeHelper, but in InArrayFunctionTypeSpecifyingExtension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#5496
closes phpstan/phpstan#5354