Add dynamicFunctionThrowTypeExtension for Reflection #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
reflection
branch
from
99684fa
to
0f914f2
Compare
VincentLanglet
force-pushed
the
reflection
branch
3 times, most recently
from
314eaea
to
e722322
Compare
ondrejmirtes
requested changes
Jun 8, 2021
| class ReflectionClassConstructorThrowTypeExtension implements DynamicStaticMethodThrowTypeExtension | ||
| { | ||
|
|
||
| private Broker $broker; |
There was a problem hiding this comment.
Broker is a deprecated class, please use ReflectionProvider instead.
|
|
||
| $valueType = $scope->getType($methodCall->args[0]->value); | ||
| foreach (TypeUtils::getConstantStrings($valueType) as $constantString) { | ||
| if (!extension_loaded($constantString->getValue())) { |
There was a problem hiding this comment.
extension_loaded isn't a useful concept because PHPStan does not require extensions to be loaded during analysis. It's best to skip this extension altogether.
VincentLanglet
force-pushed
the
reflection
branch
3 times, most recently
from
68089c1
to
601d4bd
Compare
VincentLanglet
force-pushed
the
reflection
branch
from
601d4bd
to
e611a81
Compare
|
Done, and I rebased master. I don't think the failure are related to this PR. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last throwTypeExtension I listed in #520 @ondrejmirtes