Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number_format named parameters #524

Closed
wants to merge 1 commit into from
Closed

Conversation

matyx
Copy link

@matyx matyx commented May 17, 2021

It causes error when using named parameters in number_format function:

  15     Missing parameter $dec_separator (string) in call to function number_format.    
  15     Missing parameter $num_decimal_places (int) in call to function number_format.  
  17     Unknown parameter $decimals in call to function number_format.                  
  18     Unknown parameter $decimal_separator in call to function number_format.         

Correct values are taken from documentation: https://www.php.net/manual/en/function.number-format.php

@ondrejmirtes
Copy link
Member

Hi, can you show me a failing phpstan.org link? The named parameters should already be taken from the official extracted php-src stubs: https://github.com/phpstan/php-8-stubs/blob/main/stubs/ext/standard/number_format.php

@matyx
Copy link
Author

matyx commented May 17, 2021

@ondrejmirtes
Copy link
Member

Fixed: d4fb41c

@matyx
Copy link
Author

matyx commented May 17, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants