Static analyse if date_create_from_format will fail or not #502
+94
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
date_create_from_format
and its immutable cousindate_create_immutable_from_format
can returnDateTime
/DateTimeImmutable
objects orfalse
on error.In situations where both
$format
and$datetime
parameters are known (static strings) we can check for results via phpstan and therefore prevent both unnecessary checks during runtime and false positives in phpstan (baseline).AsOOP variants should work but seem not to do...DateTime::createFromFormat()
andDateTimeImmutable::createFromFormat()
are both aliases for these functions they are covered as well.