Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lowercase variant of constant #431

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Allow lowercase variant of constant #431

merged 1 commit into from
Jan 25, 2021

Conversation

VincentLanglet
Copy link
Contributor

ondrejmirtes
ondrejmirtes requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about setrawcookie

ondrejmirtes
ondrejmirtes requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I guess the non-array setcookie variant could also use those constants.

@VincentLanglet
Copy link
Contributor Author

It should be better now @ondrejmirtes :)

@ondrejmirtes ondrejmirtes merged commit 05b1c84 into phpstan:master Jan 25, 2021
@ondrejmirtes
Copy link
Member

Thank you!

@VincentLanglet VincentLanglet deleted the allow-lowercase branch January 25, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@VincentLanglet @ondrejmirtes