-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SimpleXmlElementXpathMethodReturnTypeExtension #428
Conversation
7961271
to
8102647
Compare
$result = null; | ||
foreach (TypeUtils::getConstantStrings($argType) as $constantString) { | ||
set_error_handler(null); | ||
$newResult = $xmlElement->xpath($constantString->getValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about @
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work, but some randoms tests are failing...
return new ConstantBooleanType(false); | ||
} | ||
|
||
return new ArrayType(new MixedType(), new StaticType(\SimpleXMLElement::class)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2nd argument shouldn't be new StaticType, but $scope->getType($methodCall->var)
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ! :)
4c4259b
to
51b9767
Compare
Thank you! |
No description provided.