New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for numeric string in bc math #382
Support for numeric string in bc math #382
Conversation
3f113ff
to
459c058
Compare
Hi, thank you, you need to update the tests: it's |
@@ -78,11 +82,12 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection, | |||
* | |||
* @param FuncCall $functionCall | |||
* @param Scope $scope | |||
* @return NullType|StringType|UnionType | |||
* @return NullType|Type|UnionType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can just use @return Type
here since both NullType
and UnionType
extend Type.
Or is there a way to say tt's a String|AccessoryNumericStringType
, the TypeCombinator::intersect function returns a generic Type
though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just Type should be here.
Thank you! |
Closes phpstan/phpstan#4127