Use ReturnTypeExtension for mb_str_split #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Nov 23, 2020
| @@ -21,7 +21,8 @@ final class StrSplitFunctionReturnTypeExtension implements DynamicFunctionReturn | |||
|
|
|||
| public function isFunctionSupported(FunctionReflection $functionReflection): bool | |||
| { | |||
| return $functionReflection->getName() === 'str_split'; | |||
| return $functionReflection->getName() === 'str_split' | |||
| || $functionReflection->getName() === 'mb_str_split'; | |||
VincentLanglet
force-pushed
the
patch-1
branch
5 times, most recently
from
95660e6
to
da9c97e
Compare
VincentLanglet
force-pushed
the
patch-1
branch
from
da9c97e
to
dd0d4fa
Compare
|
@ondrejmirtes The PR seems fine to me now. But all the test are failing weirdly. |
|
Thank you! |
|
I fixed the CI with: ef6ca4a Something weird is going on with latest version of nette/di... |
Thanks you too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't
mb_str_splitwork asstr_split? @ondrejmirtesI can add tests if you think it's right.