Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FloatType equaling ConstantFloatType #375

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix FloatType equaling ConstantFloatType #375

merged 1 commit into from
Nov 18, 2020

Conversation

jlherren
Copy link
Contributor

Also add some equality tests for types.

ondrejmirtes
ondrejmirtes requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise great 👍 :)

tests/PHPStan/Type/BooleanTypeTest.php Outdated Show resolved Hide resolved
@jlherren
Fix FloatType equaling ConstantFloatType
a20b90c 
Also add some equality tests for types.
@ondrejmirtes ondrejmirtes merged commit 4a1f133 into phpstan:master Nov 18, 2020
@ondrejmirtes
Copy link
Member

Awesome, thank you!

@jlherren jlherren deleted the fix-float-equals branch November 19, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jlherren @ondrejmirtes