Explicit never early terminates #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1rdex
force-pushed
the
explicit-never-early-terminates
branch
from
6f9fd27
to
c22522d
Compare
ondrejmirtes
requested changes
Nov 2, 2020
b1rdex
force-pushed
the
explicit-never-early-terminates
branch
from
c22522d
to
fd6f35c
Compare
|
@ondrejmirtes I updated the test |
b1rdex
force-pushed
the
explicit-never-early-terminates
branch
from
fd6f35c
to
f0df73c
Compare
ondrejmirtes
requested changes
Nov 3, 2020
| @@ -10259,6 +10259,12 @@ public function dataBug4016(): array | |||
| return $this->gatherAssertTypes(__DIR__ . '/data/bug-4016.php'); | |||
| } | |||
|
|
|||
| /** @return array<string, mixed[]> */ | |||
| public function phpDocNeverEarlyTerminates(): array | |||
There was a problem hiding this comment.
Needs to start with data as any other data provider here.
| $pre = 1; | ||
| Foo::doBarPhpDoc(); | ||
| $a = 1; | ||
| assertVariableCertainty(TrinaryLogic::createYes(), $pre); |
There was a problem hiding this comment.
I'm not even sure if these are executed. They might not be. Have you seen them fail?
The typical test here should be this instead:
if (rand(0, 1)) {
$a = 1;
} else {
Foo::doBarPhpDoc();
}
assertVariableCertainty(TrinaryLogic::createYes(), $a);
|
Yeah, I just verified that the asserts are not verified because they're "dead code". I'll bring it over the finish line myselfů |
ondrejmirtes
force-pushed
the
explicit-never-early-terminates
branch
from
f0df73c
to
410c3ef
Compare
|
Thank you. There needs to be a second part - verifying that a function with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#2638