Fix resolving type of isset($arr['key']) #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, it'd be nice to also have additional regression test in the rule that produces the "Result of && is always true" message. Otherwise looks good to me 👍 |
It was buggy when $arr['key'] might be null. Fixes phpstan/phpstan#1924
ondrejmirtes
force-pushed
the
bug-1924
branch
from
9452254
to
97b1440
Compare
|
Rebased and force-pushed (I don't like merge commits), will merge it once the build passes. Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was buggy when $arr['key'] might be null.
Fixes phpstan/phpstan#1924