Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct hash function stub return type #343

Merged
merged 4 commits into from Oct 14, 2020
Merged

Correct hash function stub return type #343

merged 4 commits into from Oct 14, 2020

Commits on Oct 14, 2020

  1. Update functionMap.php 

    Correct return type of the `hash` function. [The PHP docs](https://www.php.net/manual/en/function.hash.php) say that this function always returns a string, however this is not true. It can also return a boolean `false` if you pass in the name of a non-existent hash algorithm. For example:

    var_dump(@hash('foo', 'bar', true));
    bool(false)
    @Synchro
    Synchro committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    882a87e View commit details
    Browse the repository at this point in the history

  2. Test for hash return types

    @Synchro
    Synchro committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1bbd625 View commit details
    Browse the repository at this point in the history

  3. Requested PR changes

    @Synchro
    Synchro committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    675e347 View commit details
    Browse the repository at this point in the history

  4. Add class to config.neon

    @Synchro
    Synchro committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1e6a47a View commit details
    Browse the repository at this point in the history