Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Redis::zScore() signature #319

Merged
merged 2 commits into from Sep 9, 2020
Merged

Fixed Redis::zScore() signature #319

merged 2 commits into from Sep 9, 2020

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented Sep 9, 2020

@ondrejmirtes
Copy link
Member

So can it ever be true? If not then the type should be float|false.

@lyrixx
Copy link
Contributor Author

lyrixx commented Sep 9, 2020

Good catch, fixed

@lyrixx lyrixx changed the title Fixed Reis::zScore() signature Fixed Redis::zScore() signature Sep 9, 2020
@ondrejmirtes ondrejmirtes merged commit c7a674d into phpstan:master Sep 9, 2020
@ondrejmirtes
Copy link
Member

Thank you!

@lyrixx lyrixx deleted the redis branch September 9, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lyrixx @ondrejmirtes