encode newlines in GithubErrorFormatter #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test for this scenario. |
|
turns out there was a lot of expectation changes.. hopefully thats what you had in mind. the PR seems to add coverage for a lot more code, which it actually changes - but thats great. i love it. |
|
Thank you! |
|
Fix verified.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using https://github.com/phpstan/phpstan-deprecation-rules phpstan emits multi-line error messages.
these do not get rendered properly on github.com - we only see the first line.
I guess this is related because newlines are not properly escaped.
see actions/starter-workflows#68 (comment)
inspired by a similar fix in
cs2pr: staabm/annotate-pull-request-from-checkstyle#49