IgnoreLexer: drop support for multiline identifiers #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
May 9, 2024
There was a problem hiding this comment.
- Please keep the EOL token in the array. It should be used in
parseIdentifiersto stop parsing. - There should be a test with
@phpstan-ignorefollowed by a new line to cause a parse error. - We should stop supporting trailing comma, there should be a test for that.
janedbal
force-pushed
the
ignore-lexer-no-multiline
branch
from
b37ff11
to
5b30a76
Compare
|
Added as you want. I also added more tests for current behaviour, but I think it should not be that lax and it should report any unsupported usages. Maybe, I'll try to send another MR that adjusts that. |
|
Removed the snapshot, will create separate MR with that. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.