Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make array access on possible false tolerant with isset" #3042

Closed
wants to merge 3,328 commits into from
Closed

Revert "Make array access on possible false tolerant with isset" #3042

wants to merge 3,328 commits into from

Conversation

rajyan
Copy link
Contributor

@rajyan rajyan commented May 5, 2024

Reverts #1791

ondrejmirtes and others added 30 commits March 18, 2024 17:11
@ondrejmirtes
Throw points in CallableParametersAcceptor
74c02de
@ondrejmirtes
Fix build
2c11df5
@ondrejmirtes
Refactoring to reuse getServiceClassNames in more places
4e2778b
@ondrejmirtes
Warn about possibly stale result cache with custom extensions
9338fdf
@ondrejmirtes
Merge remote-tracking branch 'origin/1.10.x' into 1.11.x
aedc049
@sayuprc @ondrejmirtes
Fix deprecated parameter order
b3622a1
@ondrejmirtes
Track invalidated $this and used variables after invoking closure
9bb4ef9
@VincentLanglet @ondrejmirtes
Fix DomDocument load return type
200641e
@staabm @ondrejmirtes
Test invalidated object in static closure
255fbff
@kamil-zacek @ondrejmirtes
Introduce ForbiddenClassNameExtension for append additional forbidden…
0f8a352 
… class prefixes
@ondrejmirtes
Merge remote-tracking branch 'origin/1.10.x' into 1.11.x
8b8e451
@ondrejmirtes
Called callable has an implicit throw point
9aa4ad8
@ondrejmirtes
Throw point when a callable is passed somewhere it's immediately exec…
2563f8d 
…uted
@ondrejmirtes
Revert to a little bit older way of doing things with by-refs from cl…
a6e08d5 
…osures
@schlndh @ondrejmirtes
fix SplObjectStorage::removeAll/Except
e8e466d
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
55ea22d
@ondrejmirtes
Test how #[Override] behaves with constructors
6769891
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
f1cf3bb
@ondrejmirtes
Get (not)analysed projectExtensionFiles from result cache
b62c5ef
@ondrejmirtes
Fix build
e0d63b0
@axlon @ondrejmirtes
Add always used method extension
030bd55
@ondrejmirtes
Project extension files - skip PHAR
7043759
@ondrejmirtes
Fix test
925c0b7
@ondrejmirtes
Merge remote-tracking branch 'origin/1.10.x' into 1.11.x
8a8b712
@ondrejmirtes
Try fixing error with duplicate class declarations
4ab7264
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
1863d22
@ondrejmirtes
One more fix
525983b
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
af24a40
@ondrejmirtes
Fix CS
0d2f4b6
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
007d476
ondrejmirtes and others added 26 commits April 23, 2024 10:11
@ondrejmirtes
Update PhpStorm stubs
26d72e8
@VincentLanglet
Filter scope by non-empty array after foreach regardless of `polluteS…
27e2b53 
…copeWithAlwaysIterableForeach`
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
1faeba3
@ttomdewit
Two new options around stricter offset checks in arrays
2450222
@ondrejmirtes
Fix build
326b985
@ondrejmirtes
Fix reportPossiblyNonexistentConstantArrayOffset
d4bf4f5
@ondrejmirtes
Fix ConstantArrayType::hasOffsetValueType() for offset union type whe…
26e949b 
…re all types are valid
@ondrejmirtes
non-empty-list always has offset 0
f4d1d48
@ondrejmirtes
Separate classes for new @param- tags
6277fb4
@janedbal @ondrejmirtes
RuleTestCase - fail on PHP warnings, notices etc.
204ab27 
Co-authored-by: Ondrej Mirtes <ondrej@mirtes.cz>
@SVillette @ondrejmirtes
fix: fix Imagick::identifyImage() return type
86f1690
@renovate @ondrejmirtes
chore(deps): update dependency shipmonk/composer-dependency-analyser …
c88f00c 
…to v1.5.3
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
d345582
@ondrejmirtes
Update renovate.json
0ded85c
@staabm
Infer object type mysqli_fetch_object (phpstan#2675)
02071ab
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
515382a
@ondrejmirtes
Update PhpStorm stubs
c544797
@schlndh
Preserve large arrays with same keys through union
6705ac1
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
b323fc3
@axlon
Introduce RuleErrorBuilder::treatPhpDocTypesAsCertainTip() for a bi…
a16184e 
…t more DRYness
@rvanvelzen @ondrejmirtes
Fix count($x) > $n === true negation
0b6d92d
@phpstan-bot
Merge branch refs/heads/1.10.x into 1.11.x
e1a61a6
@rvanvelzen @ondrejmirtes
Fix NAN not accepting NAN
c7e6244
@ondrejmirtes
Merge remote-tracking branch 'origin/1.10.x' into 1.11.x
4d162fa
@staabm @ondrejmirtes
Narrow to non-empty-string/non-falsey-string after mb_strlen()
3361c84
@ondrejmirtes
Parsing @phpstan-ignore - allow comma in description
c84a072
@rajyan
Copy link
Contributor Author

rajyan commented May 5, 2024

As explained in

phpstan/phpstan#8393

we need to handle isOffsetAccessible differently in isset.
I'm first reverting this, because offset access on 'Closure' raises an error.
#1791 (comment)

We have to handle isOffsetAccsible->maybe of 'accessibleType|false' and 'accessibleType|closure' differently.

@rajyan rajyan force-pushed the revert-1791-fix-bug-8068 branch from 07b02e3 to c84a072 Compare May 5, 2024 01:39
@rajyan rajyan closed this May 5, 2024
@rajyan rajyan deleted the revert-1791-fix-bug-8068 branch May 5, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone