Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fatal error on constant('') #3013

Open
wants to merge 10 commits into
base: 1.11.x
Choose a base branch
from
Open

Fix fatal error on constant('') #3013

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8079876
Fix fatal error on `constant('')`
staabm Apr 12, 2024
2561a62
PhpParser Name requires a non-empty-string or non-empty-array<string>
staabm Apr 12, 2024
9b1b043
toCodeString() also returns non-empty-string
staabm Apr 12, 2024
3b5cf54
Discard changes to phpstan-baseline.neon
staabm Apr 12, 2024
337342c
fix
staabm Apr 12, 2024
1de8bff
getObjectClassNames()
staabm Apr 12, 2024
4a68879
Update ReflectionProviderGoldenTest.php
staabm Apr 12, 2024
26d20dc
Update NodeScopeResolver.php
staabm Apr 12, 2024
f41fd91
namespace cannot be empty-string
staabm Apr 12, 2024
c90e17c
exception message
staabm Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Type/Php/ConstantFunctionReturnTypeExtension.php
View file
Open in desktop
Expand Up @@ -36,6 +36,9 @@ public function getTypeFromFunctionCall(

$results = [];
foreach ($nameType->getConstantStrings() as $constantName) {
if ($constantName->getValue() === '') {
return null;
}
$results[] = $scope->getType($this->constantHelper->createExprFromConstantName($constantName->getValue()));
}

Expand Down
6 changes: 6 additions & 0 deletions tests/PHPStan/Analyser/AnalyserIntegrationTest.php
View file
Open in desktop
Expand Up @@ -1330,6 +1330,12 @@ public function testBug10772(): void
$this->assertNoErrors($errors);
}

public function testBug10867(): void
{
$errors = $this->runAnalyse(__DIR__ . '/data/bug-10867.php');
$this->assertNoErrors($errors);
}

/**
* @param string[]|null $allAnalysedFiles
* @return Error[]
Expand Down
10 changes: 10 additions & 0 deletions tests/PHPStan/Analyser/data/bug-10867.php
View file
Open in desktop
@@ -0,0 +1,10 @@
<?php
namespace Bug10867;

function doFoo():void {
$sysERR = '';
?>

<p><?php echo constant($sysERR); ?></p>
<?php
}