Extension / Rule change will not invalidate the cache

[marcelthole]

Hey 👋
we have the problem that the cache file is not invalidated if we change the code inside of a custom rule.

services:
    -
        class: CustomPHPStanRule\CustomRuleA
parameters:
	inferPrivatePropertyTypeFromConstructor: true

$ cat cache/phpstan/resultCache.php  | grep -A1 "projectExtensionFiles"
        'projectExtensionFiles' => array (
        ),

I expected the CustomRuleA in the projectExtensionFile. if this is there the normal cache workflow will also check the sha1 file sum and invalidates the cache.

With the current change the current service is always added as projectExtensionFile and every change on that file will invalidate the cache

[phpstan-bot]

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

[ondrejmirtes]

Please try to reproduce the problem first. Here you can see how we typically test result cache-related problems https://github.com/phpstan/phpstan-src/blob/1.11.x/.github/workflows/e2e-tests.yml

[ondrejmirtes]

Your custom rule should be part of your analysed paths. If you fix that I don't think you'll have this problem anymore.

[marcelthole]

Result cache not used because extension file /var/www/e2e/result-cache-8/src/CustomRule.php hash does not match.

👍 nice thanks a lot for the hint