Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure http_response_header is a list<string> #2959

Open
wants to merge 4 commits into
base: 1.10.x
Choose a base branch
from
Open

Ensure http_response_header is a list<string> #2959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2a4377
Ensure http_response_header is a list<string>
Seldaek Mar 7, 2024
b64cdf4
Create http-response-header.php test
Seldaek Mar 8, 2024
33a4ba0
Run new test
Seldaek Mar 8, 2024
bcdd4f5
Add assertNativeType
Seldaek Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analyser/NodeScopeResolver.php
View file
Open in desktop
Expand Up @@ -2153,7 +2153,7 @@ static function (): void {
$functionReflection !== null
&& in_array($functionReflection->getName(), ['fopen', 'file_get_contents'], true)
) {
$scope = $scope->assignVariable('http_response_header', new ArrayType(new IntegerType(), new StringType()), new ArrayType(new IntegerType(), new StringType()));
$scope = $scope->assignVariable('http_response_header', AccessoryArrayListType::intersectWith(new ArrayType(new IntegerType(), new StringType())), new ArrayType(new IntegerType(), new StringType()));
}

if (
Expand Down
1 change: 1 addition & 0 deletions tests/PHPStan/Analyser/NodeScopeResolverTest.php
View file
Open in desktop
Expand Up @@ -1411,6 +1411,7 @@ public function dataFileAsserts(): iterable
yield from $this->gatherAssertTypes(__DIR__ . '/data/trigger-error-php7.php');
}

yield from $this->gatherAssertTypes(__DIR__ . '/data/http-response-header.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/impure-error-log.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/falsy-isset.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/falsey-coalesce.php');
Expand Down
8 changes: 8 additions & 0 deletions tests/PHPStan/Analyser/data/http-response-header.php
View file
Open in desktop
@@ -0,0 +1,8 @@
<?php

use function PHPStan\Testing\assertType;
use function PHPStan\Testing\assertNativeType;

file_get_contents('https://example.org');
assertType('list<string>', $http_response_header);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh I think you are missing another assert for assertNativeType

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok hopefully I did this correctly :)

assertNativeType('array<int, string>', $http_response_header);