Prevent ShouldNotHappenException in filter_* extensions

.github/workflows/e2e-tests.yml

@@ -206,26 +206,39 @@ jobs:
           - script: "bin/phpstan analyse -l 8 -a tests/e2e/data/timecop.php -c tests/e2e/data/empty.neon tests/e2e/data/timecop.php"
             tools: "pecl"
             extensions: "timecop-beta"
+            php-version: "8.1"
           - script: "bin/phpstan analyse -l 8 -a tests/e2e/data/soap.php -c tests/e2e/data/empty.neon tests/e2e/data/soap.php"
             extensions: "soap"
+            php-version: "8.1"
           - script: "bin/phpstan analyse -l 8 -a tests/e2e/data/soap.php -c tests/e2e/data/empty.neon tests/e2e/data/soap.php"
             extensions: ""
+            php-version: "8.1"
           - script: "bin/phpstan analyse -l 8 tests/e2e/anon-class/Granularity.php"
             extensions: ""
+            php-version: "8.1"
           - script: "bin/phpstan analyse -l 8 e2e/phpstan-phpunit-190/test.php -c e2e/phpstan-phpunit-190/test.neon"
             extensions: ""
+            php-version: "8.1"
           - script: "bin/phpstan analyse e2e/only-files-not-analysed-trait/src -c e2e/only-files-not-analysed-trait/ignore.neon"
             extensions: ""
+            php-version: "8.1"
           - script: "bin/phpstan analyse e2e/only-files-not-analysed-trait/src/Foo.php e2e/only-files-not-analysed-trait/src/BarTrait.php -c e2e/only-files-not-analysed-trait/no-ignore.neon"
             extensions: ""
+            php-version: "8.1"
           - script: |
               cd e2e/baseline-uninit-prop-trait
               ../../bin/phpstan analyse --debug --configuration test-no-baseline.neon --generate-baseline test-baseline.neon
               ../../bin/phpstan analyse --debug --configuration test.neon
+            php-version: "8.1"
           - script: |
               cd e2e/baseline-uninit-prop-trait
               ../../bin/phpstan analyse --configuration test-no-baseline.neon --generate-baseline test-baseline.neon
               ../../bin/phpstan analyse --configuration test.neon
+            php-version: "8.1"
+          - script: |
+              cd e2e/bug10483
+              ../../bin/phpstan -vvv
+            php-version: "7.2"
 
     steps:
       - name: "Checkout"
@@ -235,12 +248,17 @@ jobs:
         uses: "shivammathur/setup-php@v2"
         with:
           coverage: "none"
-          php-version: "8.1"
+          php-version: ${{ matrix.php-version }}
           tools: ${{ matrix.tools }}
           extensions: ${{ matrix.extensions }}
 
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
+      - name: "Transform source code"
+        if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3'
+        shell: bash
+        run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"
+
       - name: "Test"
         run: ${{ matrix.script }}

e2e/bug10483/bootstrap.php

@@ -0,0 +1,5 @@
+<?php
+
+// constant that's used in the Filter extension that was introduced in a later version of PHP.
+// on earlier php version introduce the same constant via a bootstrap file but with a wrong type
+if(!defined("FILTER_SANITIZE_ADD_SLASHES"))define("FILTER_SANITIZE_ADD_SLASHES",false);

e2e/bug10483/phpstan.dist.neon

@@ -0,0 +1,7 @@
+parameters:
+    level: 9
+    paths:
+        - src
+
+    bootstrapFiles:
+        - bootstrap.php

e2e/bug10483/src/bug10483.php

@@ -0,0 +1,5 @@
+<?php
+
+function doFoo(mixed $filter): void {
+    \PHPStan\Testing\assertType('non-falsy-string|false', filter_var("no", FILTER_VALIDATE_REGEXP));
+}

src/Type/Php/FilterFunctionReturnTypeHelper.php

@@ -5,7 +5,6 @@
 use PhpParser\Node;
 use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\ReflectionProvider;
-use PHPStan\ShouldNotHappenException;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Accessory\AccessoryNonEmptyStringType;
 use PHPStan\Type\Accessory\AccessoryNonFalsyStringType;
@@ -31,7 +30,6 @@
 use function is_int;
 use function octdec;
 use function preg_match;
-use function sprintf;
 use const PHP_FLOAT_EPSILON;
 
 final class FilterFunctionReturnTypeHelper
@@ -40,6 +38,8 @@ final class FilterFunctionReturnTypeHelper
 	/** All validation filters match 0x100. */
 	private const VALIDATION_FILTER_BITMASK = 0x100;
 
+	private const UNKNOWN_CONSTANT = -9999999;
+
 	private ConstantStringType $flagsString;
 
 	/** @var array<int, Type>|null */
@@ -240,7 +240,7 @@ private function getConstant(string $constantName): int
 		$constant = $this->reflectionProvider->getConstant(new Node\Name($constantName), null);
 		$valueType = $constant->getValueType();
 		if (!$valueType instanceof ConstantIntegerType) {
-			throw new ShouldNotHappenException(sprintf('Constant %s does not have integer type.', $constantName));
+			return self::UNKNOWN_CONSTANT;
 		}
 
 		return $valueType->getValue();